Draft
Conversation
This adds TMDB sync setup to the preferences.
aleiepure
reviewed
Feb 22, 2025
src/ui/preferences.blp
Outdated
| Adw.PreferencesGroup _tmdb_group { | ||
| title: C_("preferences", "The Movie Database (TMDB)"); | ||
| description: C_("preferences", "TMDB provides localized metadata for most content. Ticket Booth will download it in your prefered language, selectable below. In case it is not available, it will fallback to English US and then to the content's original language. If neither are available, it will result in a blank string. Please consider <a href='https://www.themoviedb.org/bible/new_content'>contributing to TMDB</a>. Additionally, an automatic update is performed on a frequency of your choosing."); | ||
| description: C_("preferences", "TMDB provides localized metadata for most content. Ticket Booth will download content in your preferred language, selectable below. In the event that the content is not available in your preferred language, TMDB will default to English (US) and then to the content's original language. If neither are available the result will be a blank string. Please consider <a href='https://www.themoviedb.org/bible/new_content'>contributing to TMDB</a>. \nAdditionally, an automatic update is performed on a frequency of your choosing. \nWe also support syncing with your TMDB accounts watchlist. To use this feature you will need an account on TMDB. You can create one <a href='https://www.themoviedb.org/signup'>here</a>."); |
Owner
There was a problem hiding this comment.
Line breaks format the string correctly in English but might not work well for other languages. Leave wrapping to the UI library.
Maybe the text about update frequency and account can be moved to the respective rows as a subtitle. The description was already long, but now is even longer. We need to think of a way to shorten it.
aleiepure
reviewed
Feb 22, 2025
src/ui/preferences.blp
Outdated
| vexpand: true; | ||
| hexpand: true; | ||
| title: _("Access TMDB Account"); | ||
| description: _("To sync your watchlist between Ticketbooth and TMDB you will need to give us access to your Account. We will only access your watchlist and nothing else. \n Please follow the instructions in the link that will open once you click the button below."); |
Owner
There was a problem hiding this comment.
Line breaks (see previous comment)
aleiepure
reviewed
Feb 22, 2025
src/ui/preferences.blp
Outdated
| vexpand: true; | ||
| hexpand: true; | ||
| title: _("Decide how to Sync"); | ||
| description: _("Please decide if you want to delete the local watchlist or if you want to merge your local and TMDB watchlist. \n Be careful, the first option will <b>delete</b> your local watchlist and is <b>irreversible</b>."); |
Owner
There was a problem hiding this comment.
Line breaks (see previous comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would close #25
There are some open things I need to implement therefore a draft. Opening the pull request just for you to have a look, if there is anything you don't like in there.