Skip to content

Conversation

@ernestasromeika
Copy link

Fixed a view crash when navigating to "My Games", when no games exist (i.e. on a new account).

image

Copy link
Owner

@ale64bit ale64bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! The translated terms for Spanish and Russian sound odd (in Spanish it should be "partida" and in Russian "партия" to be consistent with the rest of the interface).

Maybe it's easier instead to make prototypeItem optional and thus avoid additional localization? e.g.

(...)
final first = items.firstOrNull;
return ListView.builder(
  itemCount: items.length,
  prototypeItem: first == null ? null : _GameListTile(
    summary: first,
    (...)

@ernestasromeika
Copy link
Author

Circling back to this. I think having a message is nice, otherwise it's just a black screen (with some buttons). I used google translate for those values so that's why they don't sound very native.. (as I don't speak them). I'm down to update the translation values or remove it, your call. Will fix the conflict once we decide what to do

@ale64bit
Copy link
Owner

Circling back to this. I think having a message is nice, otherwise it's just a black screen (with some buttons). I used google translate for those values so that's why they don't sound very native.. (as I don't speak them). I'm down to update the translation values or remove it, your call. Will fix the conflict once we decide what to do

Yes, I agree that a message is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants