improve/fallback country-lookup (again)

[xerc]

'France (European Territory)' => 'France'

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@38a9ead). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff            @@
##             main      #114   +/-   ##
========================================
  Coverage        ?   100.00%           
  Complexity      ?        40           
========================================
  Files           ?         4           
  Lines           ?       102           
  Branches        ?         0           
========================================
  Hits            ?       102           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jhoff]

Not really related to this specific change, but this logic block has a bug that was introduced in d9e9584. When an empty string is passed for $value it'll return the first country in the list ( Afghanistan ) because the string length is 0, making mb_substr('', 0, 0) true.

Seems like a handful of tests would help to make sure that these lookups are working like they should.

[xerc]

Not really related to this specific change, but this logic block has a bug that was introduced in d9e9584

fyi/ strcasecmp is not used anymore

[jhoff]

fyi/ strcasecmp is not used anymore

Correct, though it was actually strncasecmp which was taking the length of 0 as the third argument. This usage was refactored to use mb_substr instead, but the bug was the same in both cases.