This repository was archived by the owner on Sep 12, 2024. It is now read-only.
Challenge2 picture upload miguelgimenez#54
Open
miguelgimenezgimenez wants to merge 66 commits intoalayagood:masterfrom
Open
Challenge2 picture upload miguelgimenez#54miguelgimenezgimenez wants to merge 66 commits intoalayagood:masterfrom
miguelgimenezgimenez wants to merge 66 commits intoalayagood:masterfrom
Conversation
miguelgimenezgimenez
force-pushed
the
challenge2-picture-upload-miguelgimenez
branch
from
1b43853 to
fcfc275
Compare
miguelgimenezgimenez
force-pushed
the
challenge2-picture-upload-miguelgimenez
branch
from
fcfc275 to
b7dc1ce
Compare
miguelgimenezgimenez
force-pushed
the
challenge2-picture-upload-miguelgimenez
branch
from
cb910d0 to
279dfc9
Compare
miguelgimenezgimenez
force-pushed
the
challenge2-picture-upload-miguelgimenez
branch
from
279dfc9 to
c4d2b7d
Compare
miguelgimenezgimenez
force-pushed
the
challenge2-picture-upload-miguelgimenez
branch
3 times, most recently
from
35f117f to
d3d77c9
Compare
miguelgimenezgimenez
force-pushed
the
challenge2-picture-upload-miguelgimenez
branch
from
d3d77c9 to
96ff699
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add picture upload functionality
I did a lot of refactoring regarding both challenges and added some tests as well as introduced Dependency injection to implement some SOLID principles
Of course there are things missing like creating a loggerService, authService... to inject to other services etc...
**NOTE: Same notes as in challenge 1 (Error handling and .nvmrc).