This repository was archived by the owner on Sep 12, 2024. It is now read-only.
Challenge1 user account management miguelgimenez#53
Open
miguelgimenezgimenez wants to merge 32 commits intoalayagood:masterfrom
Open
Challenge1 user account management miguelgimenez#53miguelgimenezgimenez wants to merge 32 commits intoalayagood:masterfrom
miguelgimenezgimenez wants to merge 32 commits intoalayagood:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add user authentication and authorization for creating and deleting posts.
Added .nvmrc file for the client because there was issues running with node version above v16.xxx.
NOTE: Errors in the backend are being caught in a centralized manner , using the express-async-errors package, which catches all errors in the controllers and the services and forwards them to the error middleware
Something similar is done in the frontend by using axios interceptors to catch all errors, some errors are still caught when some side effects for the catch are needed
This centralized way of catching errors is a bit lazy since it doesnt give you granular control for the errors but allows you to avoid using try catch in all the function blocks. IF more granularity is needed try catch should also be added, but errors are being caught anyways and the app should not break.