[#8334] Fix memleaks reported by ASAN (4-3-stable) #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanking
force-pushed
the
asan.43s
branch
2 times, most recently
from
9ad9e23 to
0c1d542
Compare
In resolveRodsTarget, when the destPath rodsPath_t is copied into targPath, it is a shallow copy. This results in both structures pointing at the same rodsObjStat_t. This causes problems for anybody using the function because the targPath and destPath in the rodsPathInp_t must be freed in a complicated manner since they are pointed at the same memory. This commit addresses the issue by making a deep copy of the rodsPath_t. In this way, the targPath owns its own rodsObjStat_t and can clean up in a deterministic manner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to run full test suite