Introduce Plugin Groups For Loading Organization#19
Open
hGriff0n wants to merge 5 commits intoalangrainger:mainfrom
Open
Introduce Plugin Groups For Loading Organization#19hGriff0n wants to merge 5 commits intoalangrainger:mainfrom
hGriff0n wants to merge 5 commits intoalangrainger:mainfrom
Conversation
Adds a quick sketch out of the interface and code changes needed to integrate "Plugin Groups" into the lazy loader plugin, as the former plugin is now unmaintained. This is specifically done in a backwards-compatible approach, where the default groups are automatically created with the current loading options. This also does not include any UI work around how to integrate into the options.
Also removes some code that supports the unimplemented "custom groups" option since the settings for that are not present.
Tries to minimize the diffs with the original repo by undoing some of the auto-formatting applied by my editor. Also tries to improve certain comments remarking on future work directions.
Undoes a change in the plugin startup logic that, on second review, was slightly different than the previous logic. Restoring the previous logic as any changes in this aspect are not the goal of the PR and it is not certain the new logic is correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates the concept of plugin "groups" from the old Plugin Groups, rebasing the prior loading options into auto-generated groups. Reimplements the existing loading mechanism to use plugin groups for the purpose of enabling future extensibility via custom groups.
This does not include the addition of any settings/ui elements for creating and editing groups as creating a "usable UI" is not really my forte (let alone, one matching the existing design language). I'm also new to Obsidian plugin development and so these changes are not explicitly tested as my system is not setup for it at the moment (can do, just don't know yet if this is a one off).
Summary: