Open
Conversation
alangrainger#44 add configurable home page option
show ipp config example in the readme
alangrainger#49 issue with video gallery
Fix alangrainger#52 lightGallery "preload" option doesn't work with infinite scrolling
alangrainger#53 Add sort order for albums
|
I just tried out your changes and they work amazing! Hopefully they can be merged at some point, but for now I'll manually overwrite the files you changed haha. Thanks for your work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there. I noticed the masonry layout needed some love after the update. I've polished the experience some more.
Functionally, I used Metafizzy's Isotope and Masonry libraries, together with imagesLoaded to provide as smooth of an experience as possible. The layout is responsive. I've retained the continuous image loading and expanded on it. I rewrote the web.js file to fit all the changes - hope it makes it more clear.
Visually, I've implemented an initial page loader and a bottom loader that appears when new batches of photos are being loaded and ordered.
Here is a sample gallery running the changes.
Hope this makes it in the main branch!