Show description in OpenGraph link previews#192
Open
esammier wants to merge 3 commits intoalangrainger:mainfrom
Open
Show description in OpenGraph link previews#192esammier wants to merge 3 commits intoalangrainger:mainfrom
esammier wants to merge 3 commits intoalangrainger:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was so glad to see #97 land in 1.15.2 that I just assumed it was for link previews too, and spent a few minutes restarting my containers wondering what I had done wrong... so I thought, might as well add it!
This adds all 3 meta tags I could find (
name="description"+ the OG and Twitter flavors) when the share has a description.The 2nd commit also rearranges the
titlemeta tags, since I'm not sure why it would depend on the imagepreviewUrlbeing set, but let me know if I'm mistaken.Thanks for the great work!