Implementation of Feature #167; loading more items in carousel mode#168
Open
fknives wants to merge 1 commit intoalangrainger:mainfrom
Open
Implementation of Feature #167; loading more items in carousel mode#168fknives wants to merge 1 commit intoalangrainger:mainfrom
fknives wants to merge 1 commit intoalangrainger:mainfrom
Conversation
Author
|
This could also be related what is described in #126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in the feature request #167 , the infinite scrolling works great to load the elements on scroll, but the same is not done in carousel mode. This PR intends to do that.
The idea is to listen to lightGallery slide events, specifically to the lgAfterSlide which is fired immediately after each slide transition.
And if we are reaching the current index or elements call the same
loadMoreItemsfunction as the scroll listener does.As a result when getting close to the final elements, more elements are loaded in