Skip to content

Conversation

@dada-engineer
Copy link
Contributor

This adds the possibility to allow the release namespace to be overridden for multi-namespace deployments in combined charts.

Fixes #25

@dada-engineer dada-engineer force-pushed the fix/25-allow-namespace-override-in-helm-chart branch 2 times, most recently from 060cf7d to 9683d4d Compare April 30, 2025 07:22
@dada-engineer dada-engineer force-pushed the fix/25-allow-namespace-override-in-helm-chart branch from 9683d4d to c05e5eb Compare April 30, 2025 07:28
@Clint-Chester
Copy link

Was looking for this before I deploy the operator 😄 thank you for this!

@akyriako
Copy link
Owner

akyriako commented May 5, 2025

Hi @dada-engineer, thanks for the contribution but I have some concerns about the changes (and the same counts for the PR #102).

The changes have been implemented directly into the charts/typesense-operator/templates/*. The thing is, that the operator-sdk (and the kubebuilder as well that operator-sdk is built upon) have a specific process for building all the kubernetes related artifacts, via kustomize check under config/*. The helm chart themselves are (re)created in this project, not an operator-sdk specific workflow step, automatically via helmify (check Makefile) which means that every time we publish a new version all these helm chart template files will be renewed and eventually your changes are gonna be overwritten!

In that way the compatibility with operator-sdk generic build workflow seems to break and extra manual steps seem to be introduced for future releases workflow (which now are limited only to change the version of the helm chart as the rest are taken over by helmify)

@dada-engineer
Copy link
Contributor Author

Thanks for noting this will check later 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typesense Operator as dependency in helm chart, operator lies in default namespace

3 participants