When OpenShift is detected, do not set the runAsUser and fsGroup #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator currently cannot be used on Openshift/OKD because of the hard-coded runAsUser and fsGroup attributes in the securitycontext.
The people behind Openshift/OKD consider hard-coded userid's a security hazard, because other pods that share the same volume and userid might access the data from the pod.
So every namespace is assigned a random range of UID's that can be used. Best practice is to omit runAsUser so that an UID from this range is automatically selected. That is what this patch does, when Openshift is detected, runAsUser and fsGroup are omitted.
With a switch this Openshift-compatibility mode can be forced to be off or on. The automatic detection is then not used.