Much breaking very incompatible: Make interfaces ADT-value pairs instead of typeclass-type (Fixes #42)#44
Open
manpages wants to merge 1 commit intoaktowns:masterfrom
Open
Much breaking very incompatible: Make interfaces ADT-value pairs instead of typeclass-type (Fixes #42)#44manpages wants to merge 1 commit intoaktowns:masterfrom
manpages wants to merge 1 commit intoaktowns:masterfrom
Conversation
This was referenced Aug 27, 2015
Closed
Author
|
If someone knows how to fix travis build — ping me. |
|
I ran |
Author
|
@kakkun61 right. This commit removes Sugar and Unsafe.Sugar. Which changes do I have to make for it to tell gulp that it shouldn't search for those? I was manually launching test suite :( |
Owner
|
Hey sorry, a delayed response. i couldn't get this pr to work with zombie + tests (had to update a bunch of stuff on master to get things to work at all) I've made a commit that makes the current test suite pass on ps 0.7.5 and removes all the warnings. Agree that a lot things need to be changed though. (just needed this on latest ps for a demo) |
Author
|
@aktowns ❤️ 💙 💜 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, TL;DR of this approach is provided in commit, discussed in #42.
Also,
Sugarremoved; tests tailored for buggy DOM implementation loosened (to match less buggy DOM implementations, such as Chromium); documentation regenerated withpulp docs; dependencies bumped.Several issues arose while working on this PR.
Please comment on this code, I want to get this over with ASAP :)