[DRAFT] Add Execute+create new block mode#4
Open
Stvad wants to merge 3 commits intoakrivka:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this replaces #3 (new branch)
This adds execute + create new code block mode (similar to shift-enter in Jupyter).
It works, but it's not quite up to a standard I want it to be - namely I'd really like the new code block to be selected after it's created. I failed to do that so far.
I've tried simulating a mouse click on the code editor and it does not work for some reason 🤔 (even though clicking directly on the roam block works, but that's not desired.
Would appreciate thoughts on how to properly do "activate new block part".
This PR also takes dependency on roam-client for some common roam-interaction functionality.