Fix AttributeError on notmuch errors#117
Open
The-Compiler wants to merge 2 commits intoakissinger:masterfrom
Open
Fix AttributeError on notmuch errors#117The-Compiler wants to merge 2 commits intoakissinger:masterfrom
The-Compiler wants to merge 2 commits intoakissinger:masterfrom
Conversation
The-Compiler
changed the title
This was added in 9a6dc59 together with passing text=True to subprocess.run(). However, with text=True, CalledProcessError.stderr is also already str, not bytes.
The-Compiler
force-pushed
the
fix-error-message-display
branch
from
fcd0549 to
722ee16
Compare
|
I can verify that this commit fixes the error, thank you! :) |
Collaborator
Author
|
I also added a second commit making it clearer that the error is from notmuch, not from Dodo. Otherwise, this can be a bit confusing: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in 9a6dc59 together with passing
text=Truetosubprocess.run().However, with
text=True,CalledProcessError.stderris also alreadystr, notbytes.Thanks to @omega-800 for spotting this!
cc @laarmen