Drop redundant wheel from PEP 517 definition#115
Open
webknjaz wants to merge 1 commit intoakissinger:masterfrom
Open
Drop redundant wheel from PEP 517 definition#115webknjaz wants to merge 1 commit intoakissinger:masterfrom
wheel from PEP 517 definition#115webknjaz wants to merge 1 commit intoakissinger:masterfrom
Conversation
It used to be a mistake in the `setuptools`' docs for a while but I've corrected it over there long ago. Sadly, many projects have been copying the snippet all over religiously. Old versions of `setuptools` depend on `wheel` when building wheels (but not sdists!). But the respective mechanism has been migrated from `wheel` (the project) into `setuptools` at last year's PyCon US (mostly by the maintainer, I helped a bit too). And so now everything is bundled. To summarize, this was never needed but going forward it's got all chances of becoming problematic in time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to be a mistake in the
setuptools' docs for a while but I've corrected it over there long ago. Sadly, many projects have been copying the snippet all over religiously.Old versions of
setuptoolsdepend onwheelwhen building wheels (but not sdists!). But the respective mechanism has been migrated fromwheel(the project) intosetuptoolsat last year's PyCon US (mostly by the maintainer, I helped a bit too). And so now everything is bundled.To summarize, this was never needed but going forward it's got all chances of becoming problematic in time.