Open
Conversation
laarmen
force-pushed
the
thread-error-handling
branch
from
2fe6f49 to
f843b68
Compare
The-Compiler
requested changes
Sep 26, 2025
Collaborator
The-Compiler
left a comment
The-Compiler
left a comment
There was a problem hiding this comment.
Yay for more error handling rather than Dodo crashing! 🙃
laarmen
force-pushed
the
thread-error-handling
branch
from
f843b68 to
0b71682
Compare
We want to gracefully handle error when calling notmuch, as well as unexpected situations such as removed messages, where the last ditch action would be to directly close the panel itself. This is fairly untested because, well, it's not that easy to recreate this kind of race condition :).
laarmen
force-pushed
the
thread-error-handling
branch
from
0b71682 to
63b73d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to gracefully handle error when calling notmuch, as well as unexpected situations such as removed messages, where the last ditch action would be to directly close the panel itself.
This is fairly untested because, well, it's not that easy to recreate this kind of race condition :).