client.py: option to return the bare SYMBOLS response unparsed

[tripleee]

Return the SYMBOLS raw response in resp_dict['raw_symbols'] in case parsing it was somehow unsuccessful.

This is an attempt at solving #1

[codecov-io]

Current coverage is 97.03%

Merging #2 into master will decrease coverage by -1.75% as of 60d4c3b

@@            master      #2   diff @@
======================================
  Files           10      10       
  Stmts          328     337     +9
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            324     327     +3
  Partial          0       0       
- Missed           4      10     +6

Review entire Coverage Diff as of 60d4c3b

Powered by Codecov. Updated on successful CI builds.

[akissa]

Since this is a deviation from the standard protocol you need to add a flag to the client options defaulting to off, the raw response should only be returned if requested by the user.

You also need to add test coverage for the changes.

[tripleee]

I was also thinking maybe that would be a better solution; but this isn't per se a deviation from the standard protocol. All the documentation says is that the SYMBOLS response is a comma-separated list of values. Maybe the parser should simply do that instead.

[akissa]

Could you provide sample output from your daemon ?

On 13 Apr 2016, at 10:14 AM, tripleee notifications@github.com wrote:

I was also thinking maybe that would be a better solution; but this isn't per se a deviation from the standard protocol. All the documentation says is that the SYMBOLS response is a comma-separated list of values. Maybe the parser should simply do that instead.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

[tripleee]

I don't think it's confidential, but I'd have to check with the vendor. In the meantime, here is a rough pseudo-code example.
String: [Values: 1.23.56.7, Key: 3], Other: [Enabled, t: (0.12346,0.456678)], Foo: [Enabled, t: (0.567234,0.054321)], Bar: [Enabled, t: (0.23456), Hit: No, Details: v1.2.3; Id: 0p9o8i7uu6y.1q2w3e4r.45ert], sum: 0(500)