GitHub Workflow for automated testing#2
Open
samiib wants to merge 44 commits intoakinross:plugin-framework-muxfrom
Open
GitHub Workflow for automated testing#2samiib wants to merge 44 commits intoakinross:plugin-framework-muxfrom
samiib wants to merge 44 commits intoakinross:plugin-framework-muxfrom
Conversation
samiib
commented
Oct 17, 2023
samiib
commented
- Tested github actions workflow
- Added format checks to workflow
- Set Test ACI credentials based on GitHub Action secrets
- Added extra log to gofmt script and add build check
…port muxing the provider with terraform plugin framework
…t muxed provider capabilities and migrate aci_annotation to new provider plugin framework
…cy and aci_pim_route_map_entry
…etwork_instance_profile, aci_l3out_management_network_oob_contract, aci_l3out_management_network_subnet and aci_out_of_band_contract
…and clean up template and required attribute overwrite
…g in documentation, and clean up templates with generator
…mat ( .html.markdown ) to new documentation directory ( /docs ) and format ( .md )
… that follow tn<class>Name format
…ST and GEN_CLASSES environment variables are set
… is prefixed with http or https
…when annotation is contained by the class in the meta file
…ild defaults and valid values.
… link to the github repository
- Changed child to block format - Fix dn description - Correctly set ElementType on content map - Correctly set id to dn - Get ClassName from ACI json response if any - Set contents based on attributes - Make sure to ignore certain contents attributes from state
- Skip seting attributes into state when not configured in contents. - Temporarily commented out child block logic as it's throwing an error while no child is configured.
- Removed old code - Started migrating test files
2. I fixed the format of the children json being sent to APIC. 3. Also stopped extra children and extra child attributes from saving in the state. This was causing errors in Terraform.
- Log a warning when trying to delete a class that cannot be deleted instead of an error. - Finished migrating existing aci_rest_managed tests.
- Added extra acceptance test - Fixed classes that doesn't support annotations. - Fixed error when rest response isn't json.
* Tested github actions workflow * Added format checks to workflow * Set Test ACI credentials based on GitHub Action secrets * Added extra log to gofmt script and add build check
akinross
force-pushed
the
plugin-framework-mux
branch
7 times, most recently
from
ab13adb to
779ed58
Compare
akinross
force-pushed
the
plugin-framework-mux
branch
from
68cfce4 to
0a38871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.