Skip to content

Conversation

@ryzanbui02
Copy link
Contributor

Summary

Notes

This is a huge PR, cause I needed to move files quite a lot.

@ryzanbui02
Copy link
Contributor Author

@akaszynski Could you take a look? The code analysis flagged the default value of extra_params as an issue, which makes sense. For now, I don’t think we need to take any action on it.

@akaszynski
Copy link
Owner

Looks like tests are failing.

@ryzanbui02
Copy link
Contributor Author

Looks like tests are failing.

@akaszynski I'm not sure where the problem is. I ran tests, everything seems to be fine in my side.

image

@akaszynski
Copy link
Owner

Looks like secrets aren't loaded on forks. Let me pull down this branch and verify tests before merging.

@akaszynski
Copy link
Owner

Tests pass locally as well.

sc003

Agree with changes. Thanks for avoiding duplication by moving common variables to constants.py and utils.py

@akaszynski akaszynski merged commit a6b748c into akaszynski:main Nov 8, 2025
2 of 7 checks passed
@ryzanbui02
Copy link
Contributor Author

@akaszynski Thank you. Have a great one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: Split interface.py into two (or more) files for better structure

2 participants