Robust parsing for malformed Wayback timestamps#197
Open
TAbdiukov wants to merge 4 commits intoakamhy:masterfrom
Open
Robust parsing for malformed Wayback timestamps#197TAbdiukov wants to merge 4 commits intoakamhy:masterfrom
TAbdiukov wants to merge 4 commits intoakamhy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wayback’s APIs sometimes return non-standard timestamps like
20100100190155(day00) or 12-digit values without seconds. These used to be parsed directly withdatetime.strptime, causingValueErrors and halting the whole executrionThis change introduces a shared
parse_wayback_datetimehelper nutils.py; and switches all Wayback timestamp parsing to use it, so timestamps are now handled centrally instead of via scattereddatetime.strptimecalls. The helper accepts 14-digit and 12-digit timestamps, normalizes values like2010-07-00, and prevents malformed Wayback timestamps from raising exceptions that previously could halt execution in the availability, CDX, or save flows.