DXE-6465 Add GithubActions workflow for unit tests#132
Open
artbookspirit wants to merge 6 commits intomasterfrom
Open
DXE-6465 Add GithubActions workflow for unit tests#132artbookspirit wants to merge 6 commits intomasterfrom
artbookspirit wants to merge 6 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds CI coverage for running Python unit tests in GitHub Actions, while also removing the legacy pkg_resources/namespace_packages namespace-package setup from the distribution.
Changes:
- Add a GitHub Actions workflow to run pytest on PRs and pushes to
main. - Remove
pkg_resourcesnamespace declaration andnamespace_packages=['akamai']packaging configuration. - Remove the manually-added
setuptoolsentry fromdev-requirements.txt.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
setup.py |
Removes namespace_packages configuration for akamai. |
dev-requirements.txt |
Removes manually-added setuptools note/dependency. |
akamai/__init__.py |
Removes pkg_resources.declare_namespace call. |
.github/workflows/unit-tests.yml |
Introduces CI workflow running pytest across a Python version matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
6
to
9
| description='{OPEN} client authentication protocol for python-requests', | ||
| url='https://github.com/akamai/AkamaiOPEN-edgegrid-python', | ||
| namespace_packages=['akamai'], | ||
| packages=find_packages(), | ||
| python_requires=">=3.10", |
| @@ -1,2 +1 @@ | |||
| """Library provides an authentication handler for requests""" | |||
Comment on lines
+27
to
+35
| - name: Install dependencies | ||
| run: pip install -r dev-requirements.txt | ||
|
|
||
| - name: Run unit tests | ||
| run: | | ||
| pytest \ | ||
| --junitxml test/tests.xml \ | ||
| --cov-report xml:test/coverage/cobertura-coverage.xml \ | ||
| --cov=akamai |
Comment on lines
6
to
9
| description='{OPEN} client authentication protocol for python-requests', | ||
| url='https://github.com/akamai/AkamaiOPEN-edgegrid-python', | ||
| namespace_packages=['akamai'], | ||
| packages=find_packages(), | ||
| python_requires=">=3.10", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.