Fix python 3.6 metaclass compatibility #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Also kudos to @encukou for his help with this PR |
gustavlarson
suggested changes
Aug 25, 2017
beanbag/namespace.py
Outdated
| conv_nmspc["__module__"] = nmspc["__module__"] | ||
| if qn is not None: | ||
| conv_nmspc["__qualname__"] = qn | ||
| if classcell is not None |
beanbag/namespace.py
Outdated
| qn = nmspc["__qualname__"] | ||
| nmspc["__qualname__"] = qn + "Base" | ||
|
|
||
| classcell = nmspc.pop('__classcell__', None) |
There was a problem hiding this comment.
Initialize classcell to None before line 107
Author
|
Thanks for taking a look at it. Made the changes you requested. |
ktdreyer
reviewed
Jan 3, 2018
beanbag/namespace.py
Outdated
| conv_nmspc["__module__"] = nmspc["__module__"] | ||
| if qn is not None: | ||
| conv_nmspc["__qualname__"] = qn | ||
| if classcell is not None: |
ktdreyer
approved these changes
May 1, 2018
StykMartin
reviewed
Apr 14, 2020
StykMartin
left a comment
StykMartin
left a comment
There was a problem hiding this comment.
Any plans for merge? Or we can consider this project as completely dead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test_sane_inheritance fail for Python 3.6
This is due to the changes done at: http://bugs.python.org/issue23722
Also some more details can be found here: https://docs.python.org/3/reference/datamodel.html#creating-the-class-object
This pull request addresses this issue for Python 3.6.