Skip to content

Revert "[WIP] Протухшие даты оплаты показываются как будущие"#44

Merged
ajnart merged 1 commit intomainfrom
revert-41-copilot/fix-4e3fc952-5e6d-4d5f-bc9a-9e72df8e5d54
Oct 2, 2025
Merged

Revert "[WIP] Протухшие даты оплаты показываются как будущие"#44
ajnart merged 1 commit intomainfrom
revert-41-copilot/fix-4e3fc952-5e6d-4d5f-bc9a-9e72df8e5d54

Conversation

@ajnart
Copy link
Copy Markdown
Owner

@ajnart ajnart commented Oct 2, 2025

Reverts #41

Summary by CodeRabbit

  • Refactor

    • Simplified subscriptions to core details (name, price, currency, domain, icon); removed next payment date and billing cycle.
    • Streamlined add/edit modal by removing related fields and live-preview elements.
    • Redesigned subscription cards to a minimal, centered layout; removed date/overdue indicators, badges, and switches; cleaner action buttons.
  • Style

    • Improved visual clarity and reduced clutter across subscription cards and previews.

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
subs Ready Ready Preview Comment Oct 2, 2025 10:43am

@ajnart ajnart merged commit a4d8a2f into main Oct 2, 2025
1 of 3 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Removed nextPaymentDate and billingCycle from the subscription model, state, and UI. Updated the store interface and defaults, simplified validation, and refactored EditSubscriptionModal to reset from the editing entity. SubscriptionCard layout was simplified to remove date/overdue logic and display only name, price, currency, domain/icon.

Changes

Cohort / File(s) Summary
Modal and form handling
app/components/EditSubscriptionModal.tsx
Dropped Zod fields nextPaymentDate and billingCycle; removed related form inputs and preview elements; switched edit flow to reset(editingSubscription); defaultValues trimmed to core fields only.
Display card simplification
app/components/SubscriptionCard.tsx
Removed date/overdue helpers and Calendar icon; deleted usage of nextPaymentDate and billingCycle; simplified layout to centered logo, name, and price; retained domain sanitization and favicon fallback.
Store model and defaults
app/store/subscriptionStore.ts
Updated Subscription interface to remove nextPaymentDate and billingCycle; adjusted defaultSubscriptions; tightened isValidSubscription to core fields with optional icon.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Modal as EditSubscriptionModal
  participant Store as subscriptionStore
  participant Card as SubscriptionCard

  User->>Modal: Open edit
  Modal->>Store: Load editingSubscription
  Note over Modal: reset(editingSubscription) (no nextPaymentDate/billingCycle)
  User->>Modal: Submit {name, price, currency, domain, icon?}
  Modal->>Store: Update subscription (core fields only)
  Store-->>Card: State change
  Card-->>User: Rerender with name/price/domain/icon
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I trimmed two dates from my carrot-led plan,
Now names and prices fit snug in the pan.
No cycles to chase, no calendars to fear—
Just crisp little cards, delightfully clear.
Thump-thump! goes the repo, light on its feet,
A bunny approves: concise and neat. 🥕✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-41-copilot/fix-4e3fc952-5e6d-4d5f-bc9a-9e72df8e5d54

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 025618e and 1788bd5.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • app/components/EditSubscriptionModal.tsx (1 hunks)
  • app/components/SubscriptionCard.tsx (3 hunks)
  • app/store/subscriptionStore.ts (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ajnart ajnart deleted the revert-41-copilot/fix-4e3fc952-5e6d-4d5f-bc9a-9e72df8e5d54 branch October 2, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant