Use crowdsourced title even if it is only a change of capitalisation and the formatter is disabled

[mschae23]

If the auto-formatter is disabled in the options and a custom title for a video is only changing capitalisation, the addon currently shows the original title instead. I don't think this makes a lot of sense – I expect the format option to control the auto-formatter, and therefore, the "disabled" option to disable that. I don't think "disabled" should mean "I don't want formatting changes", it's a lot more useful for it to result in the addon just giving me original and submitted titles as they are.

I agree to license my contribution under GPL-3.0 and agree to allow distribution on app stores as outlined in LICENSE-APPSTORE.

[ajayyy]

Hmm, I'm not sure about this behavior. Maybe if there could be a new formatting option called something like "Accept crowd-sourced formatting changes"

[mschae23]

In case you didn't see it, there's been some previous discussion at https://discord.com/channels/603643120093233162/897699762738966558/1225897417933721651 and https://discord.com/channels/603643120093233162/897699762738966558/1232036025732169849.

For me, the reasoning behind the current behaviour makes sense, but is confusing in practice.

[ajayyy]

I still don't agree with making this the default behavior for people who disabled formatting

[mschae23]

But a title that was submitted by someone will pretty much always be better than the original title, even if it's the same wording as the original. I think this makes more sense, since otherwise, the database will just not get used in this case if auto-formatting is disabled.

[mschae23]

By the way, I only touched the imports, src/titles/titleRenderer.ts:75, and src/videoBranding/videoBranding.ts:298. Not sure where all the other changes are coming from.

[ajayyy]

There is no "better" with that type of thing. It's up to someone's subjective opinion what they prefer. If they don't want formatting, then I don't see why they would automatically prefer sentence case formatting from DeArrow users