Ac pr integ without any changes#3
Open
bharath-techie wants to merge 13 commits intoajaymovva:mainfrom
Open
Conversation
…store from remote state (opensearch-project#10665) * Restore remote index shards with ExistingStoreRecoverySource after restore from remote state Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
) * Add tracing instrumentation for indexing paths Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Fix failing tests and review changes Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Fix test failures due to Span not being properly closed Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Changes to spans in primary and replica actions Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Review comments fixes and refactoring Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Precommit auto-changes Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Add refresh policy as attribute Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Fix changelog entry Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Instrument primary/replica write in TransportWriteAction instead of TransportShardBulkAction Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Modify SpanBuilder Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * spotlessApply and precommit Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Change span names Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Pass Noop Tracer instead of injected tracer Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Reverting previous changes Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> * Remove tracer variable from TransportShardBulkAction Signed-off-by: Shreyansh Ray <rayshrey@amazon.com> --------- Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
opensearch-project#10761) * [Remote Store] Fix relocation failure due to transport receive timeout Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix existing extended shardIdle for remote backed shards Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review comments Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…ling checks (opensearch-project#10751) * Update Github pull request template to have a task for inspecting failing checks Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Add failing builds troubleshooting section to CONTRIBUTING.md Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
The remote recovery thread pool does blocking I/O when downloading files, so the "half processor count max 10" was definitely too small. This can be shown by triggering recoveries on a node that is also doing segment replication, and the replication lag will increase due to contention on that thread pool. Some amount of contention is inevitable, but the change here to increase the download thread pool, and also limit the concurrent usage of that thread pool by any single recovery/replication to 25% of the threads does help. Long term, we can improve this even further by moving to fully async I/O to avoid blocking threads in the application on draining InputStreams. Signed-off-by: Andrew Ross <andrross@amazon.com>
…into account for replication lag (opensearch-project#10723) * Return unformatted segrep metrics in stats Signed-off-by: Poojita Raj <poojiraj@amazon.com> * Take upload time into account for replication time lag Signed-off-by: Poojita Raj <poojiraj@amazon.com> * unformat segrep stats Signed-off-by: Poojita Raj <poojiraj@amazon.com> * remove unused field names Signed-off-by: Poojita Raj <poojiraj@amazon.com> --------- Signed-off-by: Poojita Raj <poojiraj@amazon.com>
…estPrimaryRelocation (opensearch-project#10701) * Add primary mode check before assserting on primary mode. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * remove unnecessary shardRouting check. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add test logging. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Addressing comments on PR. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
…stats to _nodes/stats (opensearch-project#10656) * Initial WIP for adding segrep backpressure to node stats. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Bind SegmentReplicarionStatsTracker in Node.java Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * remove additional segrep backpressure info from node stats Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * fix metric name in node stats Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Fix compile error. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Fix compile errors. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Address comments on PR. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Update java docs. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Address comments on PR and fix compile errors. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Address comments on PR. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Update unit test. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Signed-off-by: Rishikesh Pasham <62345295+Rishikesh1159@users.noreply.github.com>
…rvice for RateLimiting (opensearch-project#9286) * Changes for AdmissionControl Interceptor and AdmissionControlService for RateLimiting (opensearch-project#9286) Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
…or refresh lag (opensearch-project#10803) * [Remote Store] Use time elapsed since last successful local refresh for time lag Signed-off-by: Ashish Singh <ssashish@amazon.com> * Incorporate PR review comments Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…Stats Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.