Use class_create only with AJA_CREATE_DEVICE_NODES #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since class_create/destroy are GPL-only symbols, they are not permitted to be used with a 5.9+ kernel when the proprietary nvidia_p2p symbols from a closed source NVIDIA driver are also used for RDMA support. This change makes it so that class_create/destroy are only called when AJA_CREATE_DEVICE_NODES is enabled, allowing AJA_RDMA to be enabled for 5.9+ kernels with closed source NVIDIA drivers. Note that enabling both AJA_RDMA and AJA_CREATE_DEVICE_NODES on 5.9+ kernels requires the use of an open source NVIDIA module (https://github.com/NVIDIA/open-gpu-kernel-modules).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since class_create/destroy are GPL-only symbols, they are
not permitted to be used with a 5.9+ kernel when the
proprietary nvidia_p2p symbols from a closed source NVIDIA
driver are also used for RDMA support. This change makes it
so that class_create/destroy are only called when
AJA_CREATE_DEVICE_NODES is enabled, allowing AJA_RDMA to be
enabled for 5.9+ kernels with closed source NVIDIA drivers.
Note that enabling both AJA_RDMA and AJA_CREATE_DEVICE_NODES
on 5.9+ kernels requires the use of an open source NVIDIA
module (https://github.com/NVIDIA/open-gpu-kernel-modules).