fix: Do not leak library specific defines #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRT warning levels are not something this library should set for anything that depends on the library. So most of these should remain private within the libntv2
CMAKE_BUILD_TYPE usefullness depends on the generator being used. Sometimes there is a single configure for Release and Debug and that doesn't work this way. There is an option to do config type based defines using generator expressions. Rewrote this part to include this for the NDEBUG define. NDEBUG was causing our software to be partially built with NDEBUG in debug builds causing issues with header libraries we use.
Collaborator
|
Please re-target this PR to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRT warning levels are not something this library should set for anything that depends on the library. So most of these should remain private within the libntv2