Fix Gemini Handling Youtube URLs #444
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation handling - Introduced `gcpServiceAccountEmail` configuration for service account impersonation, recommended over the legacy key method. - Updated authentication logic to support both service account impersonation and legacy service account key. - Enhanced documentation to reflect changes in GCP configuration and usage. - Adjusted file handling to accommodate new authentication methods, ensuring compatibility with existing functionality.
…ion for improved lazy evaluation - Updated blobHandler, constants, and various services to utilize getGCSBucketName for retrieving the GCS bucket name. - Enhanced error handling for GCS bucket name retrieval, ensuring it only throws errors when accessed. - Modified tests to reflect changes in GCS bucket name handling, ensuring compatibility with the new function.
GCS Updates, Deployment Scripts, Various Updates
…add dotenv to dependencies - Modified Dockerfile to use `npm ci --omit=dev` for installing only production dependencies. - Added `dotenv` to the list of dependencies in package.json, removing it from devDependencies.
…sing API key authentication
- Added port mappings for the file-handler and cortex services to expose them on a private network for Concierge access. - Updated deployment script to ensure the repository name is lowercase for Docker compatibility, improving the reliability of image pulls and environment variable settings.
- Changed the WHISPER_MEDIA_API_URL to include the /api/CortexFileHandler endpoint for improved API routing. - Removed unnecessary version declaration for cleaner configuration.
- Changed model identifiers in code_review.js and release_notes.js to reflect new versions. - Improved translation prompt in translate.js for clarity and added new parameters for enhanced processing. - Updated tool descriptions in sys_tool_browser_jina.js and sys_tool_browser.js for better user understanding and functionality adjustments.
- Updated the Gemini15VisionPlugin to check for a URL in multiple properties: gcs, image_url.url, and a new direct url property. - Improved error handling by ensuring the input is parsed correctly as JSON before processing.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 1
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug currently where youtube URLs passed to the AnalyzeVideo tool will be ignored by Gemini. This fixes it.
Note
Major infrastructure and deployment
cortexandfile-handlerimages and deploy via SSH to Hetznerdocker-compose.prod.ymlwith Traefik, Redis, Cortex, and File Handler servicesCloud storage and config
GCP_SERVICE_ACCOUNT_EMAILacrossconfig.js,lib/gcpAuthTokenHelper.js, File Handler (StorageFactory,GCSStorageProvider,blobHandler), and docsgetGCSBucketName()(lazy validation); remove silent defaultsconfig/default.jsonwith default models, entity config/constants, and service endpoints.envat startup (start.js) and adddotenvdependencyPlugins, pathways, and behavior
gs://, YouTube, HTTP/HTTPS, and data URLs (with MIME extraction)code_review.js,release_notes.js,translate.js) to use Gemini variants and tweak performance/behaviorFile handling and conversion
Tests, docs, misc
README.md,FILE_SYSTEM_DOCUMENTATION.md, and File HandlerINTERFACE.md.gitignoreWritten by Cursor Bugbot for commit 6ac204f. This will update automatically on new commits. Configure here.