Open
Conversation
aix-ahmet
approved these changes
Mar 26, 2026
aix-ahmet
reviewed
Apr 1, 2026
|
|
||
| @lru_cache(maxsize=1) | ||
| def get_user_location() -> Dict[str, str]: | ||
| """Fetch and cache the user's region and country from ipinfo.io.""" |
Collaborator
There was a problem hiding this comment.
@xainaz for on prem deployment this will not work. Assume there is no internet connection there. Lets add this as a defensive check if no internet connection keep it empty and do not shre in user info.
Collaborator
Author
There was a problem hiding this comment.
If the user doesn't have internet connection they won't be able to run agents anyway right?
Collaborator
There was a problem hiding this comment.
no, they run locally. this is for on prem setup
Collaborator
Author
There was a problem hiding this comment.
@aix-ahmet Will the except here not be enough?
It returns an empty dict if there is any issues in getting the request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.