Conversation
…il/sample Made-with: Cursor
- Updated `ReadCsvStep` to include an optional `limit` parameter for controlling the maximum number of rows read. - Modified `build_reader` function to pass the `limit` when reading CSV files. - Adjusted `head` command to set an offset of 0 when limiting rows for ORC files, ensuring correct row selection. - Refactored `select_columns_to_batches` to improve column selection logic and handle empty specifications more gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns
headwithtail/sample, adds row limit support for CSV, and unifies column selection so CLI and REPL share the same resolution and projection logic.Commits
refactor(head): use build_reader and apply_select_and_display like tail/sample
headusesbuild_reader(withlimit = Some(args.number)) instead ofread_to_batches.parse_select_stepandapply_select_and_display.Enhance CSV and ORC reading capabilities by adding row limit support
ReadCsvStepgains an optionallimit;build_readerpasseslimitfor CSV soheadcan limit rows without loading the full file.headsets offset 0 when limiting ORC for correct row selection.select_columns_to_batches(REPL) now uses the same resolution and Arrowprojectas the streamingSelectColumnsStep(no DataFusion in this path); REPLexec_selectcalls it synchronously.Summary
build_reader+ReadCsvStepsupportlimitfor streaming-style headresolve_column_specs) and one projection method (Arrowproject) for both CLI and REPLselect_columns_to_batches; empty specs return batches unchanged