Optimize REPL read |> count() to use metadata for Parquet/ORC#34
Merged
Optimize REPL read |> count() to use metadata for Parquet/ORC#34
Conversation
Made-with: Cursor
71d3b22 to
2e1a053
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the REPL pipeline is exactly
read(path) |> count(), it is now optimized to a singlecount(path)stage. For Parquet and ORC this uses file metadata only (no row data is read); for Avro and CSV it still streams batches.Key changes
optimize_read_then_count()inplan_pipeline_with_state: replaces[Read { path }, Count { path: None }]with[Count { path: Some(path) }].read(path) |> select(...) |> count()is unchanged (still three stages); only the two-stage case is optimized.test_plan_pipeline_count_no_auto_printupdated for optimized pipeline;test_plan_pipeline_read_select_count_not_optimizedadded to ensure select-in-between is not optimized.Made with Cursor