zap: Fix zap Core Write() to process fields parameter #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Write() method was only processing core.coreFields and completely ignoring the fields parameter. This caused fields passed at log time to be lost and not sent to Airbrake. Found when using logrus -> logrus-zap-hook -> zap -> airbrake/gobrake/zap, where logrus.WithFields() data was missing from Airbrake notifications. Now processes both core.coreFields (from .With()) and the fields parameter (passed at log time) to ensure all structured logging fields are captured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Write() method was only processing core.coreFields and completely ignoring the fields parameter. This caused fields passed at log time to be lost and not sent to Airbrake.
Found when using logrus -> logrus-zap-hook -> zap -> airbrake/gobrake/zap, where logrus.WithFields() data was missing from Airbrake notifications.
Now processes both core.coreFields (from .With()) and the fields parameter (passed at log time) to ensure all structured logging fields are captured.