Draft
Conversation
Main code for Serbian, by ISO 639-1, is "sr". Serbian and Bosnian have two scripts, latin and cyrillic, so I added those also. I also added, for both languages, variant with country tag (sr-RS and bs-BA) although I am not sure those are needed, but Croatian have that so why not ;) Serbian, Croatian, Bosnian and Montenegrin are basically same languages but, officially, they are different, so I separated them here.
ljharb
requested changes
Oct 1, 2020
Comment on lines
+58
to
+59
| serbian: russianPluralGroups, | ||
| bosnian: russianPluralGroups, |
Collaborator
There was a problem hiding this comment.
bosnian_serbian must be preserved, or else it's a breaking change.
Suggested change
| serbian: russianPluralGroups, | |
| bosnian: russianPluralGroups, | |
| bosnian_serbian: russianPluralGroups, | |
| serbian: russianPluralGroups, | |
| bosnian: russianPluralGroups, |
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Collaborator
|
It'd also be good to add some tests for the two added language groups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Language tag, According to IETF Language tags, can be composed of primary language tag, script tag and region tag (among some other, rarely used tags).
Main code for Serbian, by ISO 639-1, is
sr.Serbian and Bosnian have two scripts, latin and cyrillic, so I added those also, as in ISO 15924.
I also added, for both languages, region tag (
sr-RSandbs-BA), as in ISO 3166-1 alpha 2 although I am not sure those are needed, but Croatian have that so why not ;)Serbian, Croatian, Bosnian and Montenegrin are basically same languages but, officially, they are different, so I separated them here.