Add kotlin dsl support in lottie compose readme file#237
Open
markoeltiger wants to merge 1 commit intoairbnb:masterfrom
Open
Add kotlin dsl support in lottie compose readme file#237markoeltiger wants to merge 1 commit intoairbnb:masterfrom
markoeltiger wants to merge 1 commit intoairbnb:masterfrom
Conversation
the readme file was only supporting normal groovy scripts which not totally used now.
gpeal
reviewed
Oct 4, 2024
Collaborator
gpeal
left a comment
gpeal
left a comment
There was a problem hiding this comment.
I think the exact syntax from the groovy snippet should also work for kts projects. This is confirmed with a casual code search for gradle.kts files that include the snapshots repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the readme file was only supporting normal groovy scripts which not totally used now.