Merged
Conversation
Member
Author
|
@copilot fix license headers and improve documentation: in-code docs, add README with pallet usage examples and user-oriented description. |
Contributor
…let (#491) * Initial plan * Fix license headers and improve documentation for claim pallet Co-authored-by: akru <786394+akru@users.noreply.github.com> * Fix README documentation issues Co-authored-by: akru <786394+akru@users.noreply.github.com> * Add prefix to signing examples in README Co-authored-by: akru <786394+akru@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akru <786394+akru@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a new pallet-robonomics-claim that enables users to claim tokens on the Robonomics parachain by proving ownership of their Ethereum addresses through ECDSA signatures. The pallet is inspired by Polkadot's claim pallet and facilitates token migrations from Ethereum to Substrate-based chains.
Changes:
- New claim pallet implementation with unsigned transaction support for Ethereum signature verification
- Comprehensive test suite covering claim flows, edge cases, and signature validation
- Benchmarking infrastructure for weight calculation
- Integration into the Robonomics runtime with pallet index 57
- Dependencies added for ECDSA signature handling (libsecp256k1, rustc-hex)
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| frame/claim/src/lib.rs | Core pallet implementation with claim and add_claim extrinsics, Ethereum signature recovery, and token transfer logic |
| frame/claim/src/tests.rs | Comprehensive test suite covering basic claims, double-claim prevention, signature validation, and unsigned transaction validation |
| frame/claim/src/mock.rs | Mock runtime configuration for testing |
| frame/claim/src/benchmarking.rs | Benchmark implementations for claim and add_claim extrinsics plus extra benchmarks for cryptographic operations |
| frame/claim/README.md | Extensive documentation with usage examples, configuration guide, and security considerations |
| frame/claim/Cargo.toml | Pallet dependencies and feature configuration |
| runtime/robonomics/src/lib.rs | Runtime integration with pallet configuration and index assignment |
| runtime/robonomics/Cargo.toml | Added pallet dependency and std feature |
| Cargo.toml | Workspace member addition and new dependency declarations |
| Cargo.lock | Dependency resolution for new pallet |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
* Initial plan * Rename test to better reflect its purpose Co-authored-by: akru <786394+akru@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akru <786394+akru@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inspired by polkadot claim pallet. Implemented simple claim function, tests & benchmarks.