fix: Preserve timestamps in Manifest #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix addresses two issues:
1. Manifest Update Issue:
- Modified tracker to preserve file-level GeneratedAt timestamps
when file content hash hasn't changed
- Modified tracker to preserve manifest-level GeneratedAt when
no files have changed
- Added WithOldManifest() method to pass previous manifest state
- Updated update command to provide old manifest to tracker
2. Installer Script Enhancement:
- Improved error handling for GitHub API calls
- Added better error messages with troubleshooting hints
- Added debugging output showing archive name being downloaded
- Added comments clarifying GoReleaser naming compatibility
This prevents unnecessary git diffs when running webkit update with
no actual content changes, whilst still updating timestamps when
files are genuinely modified.
Includes comprehensive test coverage for timestamp preservation logic.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Updated method and field names for better clarity: - WithOldManifest() → WithPreviousManifest() - oldManifest field → previousManifest field - Updated all references in tests and comments "Previous" more clearly conveys the temporal relationship and is more commonly used in version control contexts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 64.59% 63.50% -1.10%
==========================================
Files 154 154
Lines 6064 5069 -995
==========================================
- Hits 3917 3219 -698
+ Misses 2064 1764 -300
- Partials 83 86 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Commentary and Style: - Added rule to AGENTS.md requiring all comments to end with full stops. - Fixed all inline comments in tracker.go and update.go to end with full stops. Test Organisation: - Added test organisation guidelines to AGENTS.md. - Consolidated TestTracker_WithPreviousManifest into TestTracker_Add. - Consolidated TestTracker_Add_PreservesTimestamp tests into TestTracker_Add. - Consolidated TestTracker_Save_PreservesManifestTimestamp into TestTracker_Save. - Removed redundant TestManifestTimestamp function (now covered in TestTracker_Save). - Fixed incomplete test in TestLoad for "FS Error" and "Invalid JSON" cases. This improves test maintainability by keeping related tests together and following the principle of one test function per exported function/method. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
ainsleyclark
deleted the
claude/fix-manifest-update-issues-011CUQ8cBe3MDwuGuhH8WrW2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.