fix: Missing maintenance GitHub workflow generation #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VMMaintenanceWorkflow function was only checking for DigitalOcean VMs, causing it to skip Hetzner VMs even though the template supports both providers. This resulted in the maintenance workflow not being generated for apps using Hetzner infrastructure. Updated the logic to check for both DigitalOcean and Hetzner VMs, matching the template's conditional logic. Added test cases to verify both individual Hetzner VMs and mixed provider scenarios work correctly.
ainsleyclark
deleted the
claude/fix-workflow-generation-01P7kyqaqok23snxKbsW8chq
branch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 64.59% 69.47% +4.87%
==========================================
Files 154 184 +30
Lines 6064 7279 +1215
==========================================
+ Hits 3917 5057 +1140
+ Misses 2064 2025 -39
- Partials 83 197 +114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VMMaintenanceWorkflow function was only checking for DigitalOcean VMs, causing it to skip Hetzner VMs even though the template supports both providers. This resulted in the maintenance workflow not being generated for apps using Hetzner infrastructure.
Updated the logic to check for both DigitalOcean and Hetzner VMs, matching the template's conditional logic. Added test cases to verify both individual Hetzner VMs and mixed provider scenarios work correctly.