tighten multi-file experiment validation#195
Open
CKwin26 wants to merge 1 commit intoaiming-lab:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__init__and only implement one core methodWhy
Generated experiment projects are increasingly multi-file. The validator was missing two important cases:
At the same time, duplicated class definitions across files like
main.pyandmodels.pyare a real failure mode for generated projects and should be surfaced explicitly.Changes
deep_validate_files(...)Validation
python -m pytest -q tests/test_rc_executor.py -k "deep_validation_detects_undefined_helper_calls or deep_validation_allows_inherited_single_core_method_subclass or deep_validation_detects_duplicate_algorithm_classes_across_files"python3 -m compileall researchclaw/experiment/validator.py tests/test_rc_executor.py