Skip to content

Developments not fully integrated yet#24

Draft
mbercx wants to merge 1 commit intoaiidateam:mainfrom
mbercx:tmp/dev
Draft

Developments not fully integrated yet#24
mbercx wants to merge 1 commit intoaiidateam:mainfrom
mbercx:tmp/dev

Conversation

@mbercx
Copy link
Member

@mbercx mbercx commented Dec 4, 2024

Note: Comments below may be outdated, just opening a PR to check and share changes.

  1. Allow user to specify unique keys upon instantiation.
  2. Add order_by input which can be passed to the parent node query.
  3. Verbose submission now has a formatted table.

1. Allow user to specify unique keys upon instantiation.
2. Add `order_by` input which can be passed to the parent node query.
3. Verbose submission now has a formatted table.
@mbercx
Copy link
Member Author

mbercx commented Dec 4, 2024

Yup, seems some of the developments here have already been integrated. ^^ So this PR will most likely only be for the formatted table of the verbose submission.

Not sure if we should keep the changes regarding the exceptions... I don't like a bare Exception catch, so maybe it's good to be more specific, but not catching the exceptions is a pain.

@mbercx
Copy link
Member Author

mbercx commented Dec 4, 2024

Ah, seems the verbose table is also already integrated, now it's just duplicated 😂

So let's just think on the exceptions and maybe close this PR.

@mbercx mbercx force-pushed the main branch 3 times, most recently from 9aa909f to a564fe9 Compare December 10, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant