Closed
Conversation
Member
|
Thanks @khsrali! I had made similar changes locally, but still wanted to have a v1.X-compatible release before updating everything, but just never got around to it. |
Contributor
Author
|
Thanks @mbercx, connection on the glacier seems to be really good, ha. |
Collaborator
Member
|
Thanks again @khsrali! If you're ok with it, I'm going to split this PR up in 3 commits:
Note that if we merge this PR, anyone using |
Contributor
Author
|
@mbercx all good, do whatever you think is convenient 👍 |
9aa909f to
a564fe9
Compare
Member
|
Superseded by #26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo is outdated with respect to
aiida-core v2.6I need this update to perform some performance test for
aiida-firecrestThe main changes in this PR are as follows:
aiida-core v2.6orm.Group.objects.getorm.Group.collection.getorm.Group.objects.get_or_createorm.Group.collection.get_or_createpydantic v2.8.2:@validator@field_validatornot needed anymoreallow_reuse=True/examples/add_in_batches.pyload_profile()