Closed
Conversation
Added `ShellGenerator` class to streamline different shell commands. Currently, it takes the `shell_str` as instance variable to select the appropriate code, while `shell_str` and `env_file_path` are populated in the `.format()` call when the shell commands are returned. This still seems a bit clunky, any ideas how to improve that? Added `from_env_file` classmethod to `ProjectConfig` to populate config instance from .env file. Renamed set_key/get_key to write_key/read_key. Instantiation of `ProjectConfig` passing default arguments of `aiida_venv_dir` and `aiida_project_dir`, as setting inside ProjectConfig did not seem to have intended effect?
Member
|
@GeigerJ2 thanks for the contribution, and sorry for only coming back to this now... Do you mind if I make some changes directly on top of this PR? |
Member
Collaborator
Author
|
Took it for a spin at the version of PR #16 and everything seemed to work fine. I'm happy with the changes, so we can close this and approve the other ones? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
ShellGeneratorclass to streamline different shell commands. Currently, it takes theshell_stras instance variable to select the appropriate code, whileshell_strandenv_file_pathare populated in the.format()call when the shell commands are returned. This still seems a bit clunky, any ideas how to improve that?Added
from_env_fileclassmethod toProjectConfigto populate config instance from .env file. Renamed set_key/get_key to write_key/read_key.Instantiation of
ProjectConfigpassing default arguments ofaiida_venv_dirandaiida_project_dir, as setting inside ProjectConfig did not seem to have intended effect?