More typing + enable strict mypy checking#40
Merged
mbercx merged 1 commit intoaiidateam:mainfrom Oct 1, 2025
Merged
Conversation
danielhollas
commented
Oct 1, 2025
| def set_key(self, key, value): | ||
| dotenv.set_key(self.model_config["env_file"], key, value) | ||
|
|
||
| def get_key(self, key): |
Collaborator
Author
There was a problem hiding this comment.
get_key has not been used anywhere so I just removed it for now.
danielhollas
commented
Oct 1, 2025
|
|
||
|
|
||
| def recursive_mkdir(project_path: Path, structure: dict | list | Path) -> None: | ||
| def recursive_mkdir(project_path: Path, structure: dict | list | Path) -> None: # type: ignore[type-arg] |
Collaborator
Author
There was a problem hiding this comment.
The type ignores here are just for brevity of type annotations ---- otherwise I would have to spell out Any as generic type parameters everywhere...
mbercx
approved these changes
Oct 1, 2025
Member
mbercx
left a comment
mbercx
left a comment
There was a problem hiding this comment.
LGTM! Thanks as always @danielhollas 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ended up being surprisingly easy so I just went for it.
Without the strict mode mypy is actually very lenient and it's easy for it to miss bugs (e.g. through missing type annotations).