Conversation
danielhollas
force-pushed
the
install-deps-together
branch
from
bb0a2e1 to
7b59312
Compare
|
@mbercx LMK if you agree with the direction of this PR. I quite like how this turned out to be a big code simplification, without needing to remove the "install additional plugin" features. |
danielhollas
changed the title
danielhollas
force-pushed
the
install-deps-together
branch
2 times, most recently
from
f76f0c6 to
f46d3ac
Compare
mbercx
left a comment
mbercx
left a comment
There was a problem hiding this comment.
Thanks @danielhollas! I left some small fixes and a question, but I like the code simplification a lot. Note that you are also removing the (actually broken, see #38) feature of installing from a GitHub. I'm fine with removing it for sure, we can always see if we want to reintroduce it in the future.
|
Okay, I added an error handling for the 
This is good to go from my side, @mbercx feel free to adjust and fix commits as you please, it's getting late here. 😅 |
|
Note: The error handling needs to be added to all |
Yes. To be precise, I am removing the ability to have a cloned local repo installed in an editable mode. You can still install packages directly from github (as demonstrated by the added test in the CI). |
Correct, apologies for the careless language, this is what I meant. We'll see later if we want this feature to be reintroduced (and working this time 🙈).
Alright, thanks again @danielhollas! I'll adapt and merge then 🙏 |
The `--plugin` option of the `create` command allows the user to install additional
packages next to `aiida-core`. In the current approach these are installed one by one
after completing the installation of `aiida-core`. Moreover, if any of the package
installations failed, this would do so silently.
Here we improve the installation step by installing all packages in one go, which
makes it easier for the resolver to take into account all constraints. Additionally,
any errors are now caught and shown to the user.
This commit also removes the broken feature to clone packages from their GitHub
repository and install them locally. Note that installing packages from GitHub is still
possible using the typically `pip` syntax `git+`:
aiida-project create test -p git+https://github.com/aiidateam/aiida-quantumespresso
The repo is simply no longer cloned to the `git` directory`. This directory is also
removed from the default project layout, since it was confusing to refer to it due to
the similarity with the `.git` directory.
Co-authored-by: Daniel Hollas <daniel.hollas@bristol.ac.uk>
mbercx
force-pushed
the
install-deps-together
branch
from
2bf3b83 to
5fb8750
Compare
|
Thanks again @danielhollas, great work as always. 🙌 |
2 participants
Implementation of #30 (comment)