Add support for --external-source to shellcheck_aspect#54
Merged
aignas merged 1 commit intoaignas:mainfrom Mar 19, 2026
Merged
Conversation
Contributor
Author
|
@aignas It would also be super nice to have a new release for this change as well. |
Contributor
Author
|
@aignas friendly ping here 😄 |
Contributor
Author
|
@aignas one more ping 🙏 |
aignas
approved these changes
Mar 19, 2026
Owner
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
Thank you! Sorry, it's been a little busy on my side, greatly appreciate the help out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to #53 but only implements this support for
shellcheck_aspect. The reason for comes fromshellcheck_aspecthaving baked in assumptions around operating exclusively onsh_*rules (related to bazel-contrib/rules_shell#16) which enabled the rules to further align with adding this support forrules_shelltargets with the aspect.This change also eliminates the unnecessary generation of files for each time the aspect runs.