-
Notifications
You must be signed in to change notification settings - Fork 14
Refactors to support Spacewalk #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the build toolchain from Rollup to Vite and the test framework from Mocha/Chai to Vitest. The changes include:
- Migration from Rollup to Vite for bundling
- Test framework migration from Mocha/Chai to Vitest
- Removal of Babel configuration
- Addition of extensive Spacewalk integration code for live maps
- Refactoring of dataset architecture to support both static Hi-C files and dynamic live maps
- CSS build improvements with SCSS module system
Reviewed Changes
Copilot reviewed 33 out of 45 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated build tool dependencies from Rollup to Vite, test framework from Mocha to Vitest |
| vite.config.js | New Vite configuration for building library bundles |
| vitest.config.js | New Vitest configuration for running tests |
| vite-plugin-version.js | Custom Vite plugin to update version from package.json |
| js/hicDataset.js | Refactored to abstract base class with HiCDataset subclass |
| js/liveMapDataset.js | New dataset implementation for live/computed contact maps |
| js/hicBrowser.js | Updated to support multiple dataset types with activeDataset/activeState |
| test/*.js | Migrated tests from Mocha/Chai to Vitest |
| css/juicebox.scss | Updated to use SCSS module system with @use |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.