Skip to content

Conversation

@turner
Copy link
Collaborator

@turner turner commented Nov 7, 2025

No description provided.

@turner turner requested a review from Copilot November 7, 2025 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the build toolchain from Rollup to Vite and the test framework from Mocha/Chai to Vitest. The changes include:

  • Migration from Rollup to Vite for bundling
  • Test framework migration from Mocha/Chai to Vitest
  • Removal of Babel configuration
  • Addition of extensive Spacewalk integration code for live maps
  • Refactoring of dataset architecture to support both static Hi-C files and dynamic live maps
  • CSS build improvements with SCSS module system

Reviewed Changes

Copilot reviewed 33 out of 45 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
package.json Updated build tool dependencies from Rollup to Vite, test framework from Mocha to Vitest
vite.config.js New Vite configuration for building library bundles
vitest.config.js New Vitest configuration for running tests
vite-plugin-version.js Custom Vite plugin to update version from package.json
js/hicDataset.js Refactored to abstract base class with HiCDataset subclass
js/liveMapDataset.js New dataset implementation for live/computed contact maps
js/hicBrowser.js Updated to support multiple dataset types with activeDataset/activeState
test/*.js Migrated tests from Mocha/Chai to Vitest
css/juicebox.scss Updated to use SCSS module system with @use

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

turner and others added 2 commits November 7, 2025 09:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link

Copilot AI commented Nov 7, 2025

@turner I've opened a new pull request, #401, to work on those changes. Once the pull request is ready, I'll request review from you.

@turner turner merged commit 306cd1d into master Nov 7, 2025
@turner turner deleted the spacewalk-refactor branch November 7, 2025 14:45
@turner turner restored the spacewalk-refactor branch November 7, 2025 14:48
@turner turner deleted the spacewalk-refactor branch November 7, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants