Remove redundant compose up from CI #125
Closed
+49
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sehkone
commented
Jan 16, 2026
sehkone
commented
- Drop the standalone docker compose up and wait steps.
- Keep a single build before infra up to avoid duplicate restarts and reduce CI time.
- Drop the standalone docker compose up and wait steps. - Keep a single build before infra up to avoid duplicate restarts and reduce CI time.
Start the bootroot-agent container in CI and check its logs for successful issuance. Keep oneshot verification for CLI flow coverage.
Move bootroot-agent container start after verify to avoid certs permission conflicts. Keep sidecar launch for the E2E log check step.
Contributor
Author
|
This shows no benefit at all. So, it will not be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.