Skip to content

Conversation

@SprGrf
Copy link
Contributor

@SprGrf SprGrf commented Nov 17, 2025

Description

Updates for v5.

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@SprGrf SprGrf requested a review from eeberhard as a code owner November 17, 2025 12:29
@SprGrf SprGrf changed the title docs:v5 - frames docs: v5 - frames Nov 17, 2025
Copy link
Member

@bpapaspyros bpapaspyros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small things, looks good

Comment on lines 33 to 36
1. Frames are created at the origin of the scene and have reference frame `world` by default.

2. Frames can also be created with the 3D view in the right panel. The option can be found under the `Settings` menu on
the top left of the scene.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we split this to a note and a tip ? mostly visual, but also to keep them somewhat separated. But the current version works as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt that a note and a tip, with their different colors, would be a bit more cluttering visually. We could do it like that though, not a big issue.

Copy link
Member

@bpapaspyros bpapaspyros Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no strong opinion here, just making the recommendation. Let's see what the others prefer. I didn't find the current version difficult to read, to be fair

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we would be less specific before, this is not even required

Co-authored-by: Vaios Papaspyros <8146703+bpapaspyros@users.noreply.github.com>
Using the "Create a frame" dropdown in the 3D scene view in AICA Studio, users can create a new named frame which can
then be dragged to the desired location in the scene. The position, orientation and reference frame of the frame appear
under `frames` in the application YAML and are updated on drag.
With the 3D scene on the main view of the AICA Studio editor, the "Create a frame" option in the Settings section of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads very heavy IMO. Couldn't we generalize this to saying "In the 3D scene settings". It should be clear by now that these settings can be accessed in two ways

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but this is the actual frames guide. If it was a different one, we could mention it like that, more generic, but this is the place to be describe more in detail I think.

Copy link
Member

@domire8 domire8 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't #390 maybe going to introduce this? In any case, it might be clearer then to first introduce here the two ways of getting to the settings and then go into recording or creating frames

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be a more general description, and not where you can find settings such as these specifically.

But this might be a good idea, I will rephrase.

Comment on lines 33 to 36
1. Frames are created at the origin of the scene and have reference frame `world` by default.

2. Frames can also be created with the 3D view in the right panel. The option can be found under the `Settings` menu on
the top left of the scene.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we would be less specific before, this is not even required

Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it better

SprGrf and others added 2 commits November 18, 2025 11:15
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool with the video files!!!

Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we need manual line breaks here to have a space between the video and the text

Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nits, then you can merge. Thanks

@domire8 domire8 changed the title docs: v5 - frames docs: v5 - application frames Nov 19, 2025
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
@SprGrf SprGrf merged commit cfd3df0 into main Nov 19, 2025
@SprGrf SprGrf deleted the docs/v5-frame branch November 19, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants