Combine timed vault actions, fully support sbtc and dao tokens #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will replace the other three, waiting until tested.
Now 5 instead of 7
We can use the (and) short circuit to just make the call or not, but the print event and message would go through so better to fail here and let (ok false) propagate in the conclude tx.
Single describe block, it with function name
…-only function coverage
Also caught one more spot to remove old payments-invoices code.
This is really a band-aid to make sure the check looks at all other contracts files, it excludes the trait directory by default for the dao but the smart wallet trait lives next to the file. Probably some reorg of the files can fix this but for now the test will just exclude matching a test file for any contract name that includes "traits".
Since we print the allow-asset event for each allowed we can simplify this, the return type using map over the private function and the trait were not lining up.
whoabuddy
changed the title
This was referenced Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work completed:
Left off:
verify all default amounts and ranges are correctmoved to Verify default and range limits for timed-vault contracts #55Breaking changes:
aibtc-action-allow-assettoaibtc-action-treasury-allow-assetaibtc-action-set-account-holderaibtc-action-set-withdrawal-amountaibtc-action-set-withdrawal-periodaibtc-timed-vaultto 3 versions-stx-sbtcand-daoaibtc-action-configure-timed-vaultto 3 versions-stx-sbtcand-daodeposit-stxtodepositandwithdraw-stxtowithdraw-pmt-shorthand for payment processor in longer contract names(ok true)when completeget-total-proposals()is now a tuple:{ total: uint, concluded: uint, executed: uint }