Skip to content

Conversation

@whoabuddy
Copy link
Contributor

No description provided.

Doing so closes the market so unable to continue test. Old values were related to STX and 6 decimals, now it's sBTC using 8 decimals with 0.04 sBTC target in dex iirc.
Now includes helpers to make it easy to compute the liquid supply from on-chain values and compare that to contract print events.
Between 8 decimals and small amounts was running into an err u3 amount to send is non-positive, narrowed it down to fee and pre-fee calculations in the dex, if the number is less than 1 it becomes 0 causing the function to fail.
Makes it easier to specify settings depending on what's needed.
Timed vault is so much better than bank account.
@codecov
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 43.24324% with 21 lines in your changes missing coverage. Please review.

Project coverage is 50.24%. Comparing base (56bd1d2) to head (ea077a7).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...sals/aibtc-timed-vault-initialize-new-account.clar 0.00% 4 Missing ⚠️
...ts/dao/proposals/aibtc-base-replace-extension.clar 0.00% 3 Missing ⚠️
contracts/dao/extensions/aibtc-timed-vault.clar 0.00% 2 Missing ⚠️
...ts/dao/proposals/aibtc-base-disable-extension.clar 0.00% 2 Missing ⚠️
contracts/dao/aibtc-base-dao.clar 0.00% 1 Missing ⚠️
...ts/dao/proposals/aibtc-base-add-new-extension.clar 0.00% 1 Missing ⚠️
...cts/dao/proposals/aibtc-base-enable-extension.clar 50.00% 1 Missing ⚠️
...s/dao/proposals/aibtc-timed-vault-deposit-stx.clar 0.00% 1 Missing ⚠️
...tc-timed-vault-override-last-withdrawal-block.clar 0.00% 1 Missing ⚠️
...roposals/aibtc-timed-vault-set-account-holder.clar 0.00% 1 Missing ⚠️
... and 4 more

❌ Your patch status has failed because the patch coverage (43.24%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   49.16%   50.24%   +1.07%     
==========================================
  Files          66       66              
  Lines        2266     2287      +21     
  Branches      335      338       +3     
==========================================
+ Hits         1114     1149      +35     
+ Misses       1144     1129      -15     
- Partials        8        9       +1     
Files with missing lines Coverage Δ
contracts/aibtc-user-agent-smart-wallet.clar 92.37% <ø> (ø)
...sions/actions/aibtc-action-set-account-holder.clar 100.00% <100.00%> (ø)
...ns/actions/aibtc-action-set-withdrawal-amount.clar 90.00% <100.00%> (ø)
...ns/actions/aibtc-action-set-withdrawal-period.clar 90.00% <100.00%> (ø)
...acts/dao/extensions/aibtc-action-proposals-v2.clar 95.50% <100.00%> (+0.05%) ⬆️
...tracts/dao/extensions/aibtc-core-proposals-v2.clar 95.80% <100.00%> (+0.05%) ⬆️
...sals/aibtc-action-proposals-set-proposal-bond.clar 100.00% <ø> (ø)
...posals/aibtc-base-bootstrap-initialization-v2.clar 100.00% <100.00%> (ø)
...proposals/aibtc-base-bootstrap-initialization.clar 50.00% <100.00%> (ø)
...posals/aibtc-core-proposals-set-proposal-bond.clar 100.00% <ø> (ø)
... and 15 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@whoabuddy whoabuddy merged commit 2fd9b8f into main Mar 15, 2025
3 of 4 checks passed
@cedarxyz cedarxyz moved this to Todo in AIBTC Sprint Board Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants