-
Notifications
You must be signed in to change notification settings - Fork 3
Consistency review #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing so closes the market so unable to continue test. Old values were related to STX and 6 decimals, now it's sBTC using 8 decimals with 0.04 sBTC target in dex iirc.
Now includes helpers to make it easy to compute the liquid supply from on-chain values and compare that to contract print events.
Between 8 decimals and small amounts was running into an err u3 amount to send is non-positive, narrowed it down to fee and pre-fee calculations in the dex, if the number is less than 1 it becomes 0 causing the function to fail.
Makes it easier to specify settings depending on what's needed.
Timed vault is so much better than bank account.
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (43.24%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 49.16% 50.24% +1.07%
==========================================
Files 66 66
Lines 2266 2287 +21
Branches 335 338 +3
==========================================
+ Hits 1114 1149 +35
+ Misses 1144 1129 -15
- Partials 8 9 +1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.